Share primitive binary operand decoding - #9295
Merged
Merged
Conversation
Move primitive array and constant decoding out of numeric execution so comparison does not depend on a numeric implementation detail. Numeric and comparison keep the same input classification and execution behavior. Signed-off-by: "Connor Tsui" <connor.tsui20@gmail.com>
Merging this PR will improve performance by 13.05%
Performance Changes
Tip Curious why this is faster? Comment Comparing Footnotes
|
connortsui20
marked this pull request as ready for review
August 8, 2026 01:48
robert3005
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Primitive comparison currently imports
PrimitiveOperandthrough numeric execution. This moves the decoder to the binary module so both implementations depend on a neutral location.Just thought it was weird where it is now