Skip to content

Share primitive binary operand decoding - #9295

Merged
connortsui20 merged 1 commit into
developfrom
ct/primitive-binary-operands
Aug 8, 2026
Merged

Share primitive binary operand decoding#9295
connortsui20 merged 1 commit into
developfrom
ct/primitive-binary-operands

Conversation

@connortsui20

@connortsui20 connortsui20 commented Aug 8, 2026

Copy link
Copy Markdown
Member

Rationale for this change

Primitive comparison currently imports PrimitiveOperand through numeric execution. This moves the decoder to the binary module so both implementations depend on a neutral location.

Just thought it was weird where it is now

Move primitive array and constant decoding out of numeric execution so comparison does not depend on a numeric implementation detail. Numeric and comparison keep the same input classification and execution behavior.

Signed-off-by: "Connor Tsui" <connor.tsui20@gmail.com>
@connortsui20 connortsui20 added the changelog/chore A trivial change label Aug 8, 2026
@connortsui20
connortsui20 requested a review from robert3005 August 8, 2026 01:44
@codspeed-hq

codspeed-hq Bot commented Aug 8, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 13.05%

⚡ 5 improved benchmarks
✅ 1939 untouched benchmarks
⏩ 85 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation take[small_m/shuffled/primitive/nonnull/chunks=1024/indices=1000] 6.4 ms 5.6 ms +14.52%
Simulation take[small_m/shuffled/primitive/nonnull/chunks=1024/indices=256] 2.4 ms 2.1 ms +14.34%
Simulation take[small_m/shuffled/primitive/nonnull/chunks=16384/indices=1000] 10.8 ms 9.6 ms +13.03%
Simulation take[core/shuffled/primitive/nonnull/chunks=1024/indices=10000] 14.8 ms 13.1 ms +12.28%
Simulation decompress[u64, (1000, 16)] 72.2 µs 64.9 µs +11.1%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ct/primitive-binary-operands (3c1d820) with develop (5794e7d)

Open in CodSpeed

Footnotes

  1. 85 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@connortsui20
connortsui20 marked this pull request as ready for review August 8, 2026 01:48
@connortsui20
connortsui20 requested a review from gatesn August 8, 2026 01:49
@connortsui20
connortsui20 merged commit 66d096b into develop Aug 8, 2026
94 of 95 checks passed
@connortsui20
connortsui20 deleted the ct/primitive-binary-operands branch August 8, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants