Skip to content

Remove the unused StrictComparison::to_compare_operator - #9405

Draft
connortsui20 wants to merge 1 commit into
claude/github-issue-9212-ia0abifrom
ct/remove-to-compare-operator
Draft

Remove the unused StrictComparison::to_compare_operator#9405
connortsui20 wants to merge 1 commit into
claude/github-issue-9212-ia0abifrom
ct/remove-to-compare-operator

Conversation

@connortsui20

Copy link
Copy Markdown
Member

Rationale for this change

Its last caller was the between_canonical fallback, which #9404 rewrote to build its operators with to_operator. Nothing else in the workspace calls it, and it is pub const fn, so no dead-code lint will report it later.

What changes are included in this PR?

Deletes the method and the CompareOperator import it needed. Split out from #9404 because StrictComparison is public and eight crates use it, so removing a method from it is a separate decision from a semantics fix.

What APIs are changed? Are there any user-facing changes?

StrictComparison::to_compare_operator is gone. No caller exists in the workspace, but it was reachable, so this is a public API removal. to_operator covers the same need and returns the Operator that callers actually want.


Generated by Claude Code

Its last caller was the `between_canonical` fallback, which now builds its
operators with `to_operator`. Nothing else in the workspace called it. Removing
it also drops the `CompareOperator` import from the module.

This is a public API removal on a type that eight crates use, so it is split
out from the fix that orphaned it.

Signed-off-by: "Connor" <connor@spiraldb.com>

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012Kc2AuwyEzVQBJLMbfVV36
@codspeed-hq

codspeed-hq Bot commented Aug 13, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 13.85%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

❌ 2 regressed benchmarks
✅ 1992 untouched benchmarks
⏩ 89 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation cold_misaligned[(64, 256)] 4.4 ms 5.3 ms -16.96%
Simulation compress_fsst[(1000, 64, 8)] 1 ms 1.2 ms -10.63%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ct/remove-to-compare-operator (41a7eaa) with claude/github-issue-9212-ia0abi (33cbc33)

Open in CodSpeed

Footnotes

  1. 89 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants