Skip to content

Conversation

@Sand-jrd
Copy link
Contributor

Replacement the content of sci_cube_skysub with the DIKL procedure as explained in [REN23].

In pca_fullfr, the mask_rdi has been (re)-added to _adi_rdi_pca and is used along with sci_cube_skysub when it is provided. If not, it follows the procedure in place.

The argument mask_rdi in docstring has been updated accordingly and reference to [REN23] have been added.

Exemple :

To create masks

from vip_hci.var import get_annulus_segments
import numpy as np

ones= np.ones((350,350))
coro = 8
cring_out = 110
cring_in = 70

boat = get_annulus_segments(ones,coro,cring_out-coro, mode="mask")[0]
anchor = get_annulus_segments(ones,cring_in,cring_out-cring_in, mode="mask")[0]

image

Usage with pca

from vip_hci.psfsub import pca
res = pca(cube, angles, ref, mask_rdi=(anchor, boat), ncomp=2)
image

Replace the content of sci_cube_skysub with the DIKL procedure as explained in [REN23].
In pca_fullfr, the mask_rdi has been added to _adi_rdi_pca and is used along with sci_cube_skysub when it is provided. If not, it follows the procedure in place.
The argument mask_rdi in docstring has been updated accordingly.
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 55.33981% with 46 lines in your changes are missing coverage. Please review.

Project coverage is 52.13%. Comparing base (d9f1bef) to head (3a9bbf6).

Files Patch % Lines
vip_hci/psfsub/pca_fullfr.py 35.00% 26 Missing ⚠️
vip_hci/preproc/skysubtraction.py 68.25% 20 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #629      +/-   ##
==========================================
+ Coverage   51.88%   52.13%   +0.25%     
==========================================
  Files          87       87              
  Lines       16365    16404      +39     
==========================================
+ Hits         8490     8551      +61     
+ Misses       7875     7853      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VChristiaens
Copy link
Contributor

Thanks @Sand-jrd !

@VChristiaens VChristiaens merged commit 3d2e330 into vortex-exoplanet:master Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants