Skip to content

Conversation

@jmilou
Copy link
Contributor

@jmilou jmilou commented Jan 25, 2025

The pull request adds a new function to scattered_light_disk.py: the possibility to generate a map with the scattering angles in the disk mid plane (useful to see which scattering angles correspond to which part of the disk).
Another change allows the star to be at a position different from the center of the image .

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 17.64706% with 14 lines in your changes missing coverage. Please review.

Project coverage is 28.96%. Comparing base (4a8e9cf) to head (ad68205).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
vip_hci/fm/scattered_light_disk.py 17.65% 14 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #659      +/-   ##
==========================================
- Coverage   33.13%   28.96%   -4.17%     
==========================================
  Files          87       87              
  Lines       16696    16712      +16     
==========================================
- Hits         5531     4839     -692     
- Misses      11165    11873     +708     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VChristiaens VChristiaens merged commit aa26b1e into vortex-exoplanet:master Jan 28, 2025
14 checks passed
@VChristiaens
Copy link
Contributor

Thanks a lot @jmilou !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants