New (I)PCA features and a minor bug fix #661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
VChristiaens
commented
Feb 26, 2025
VChristiaens
commented
- bug fix in get_mu_and_sigma for 4D input cube and input flux guess
- Defined a utility function to return PCA coefficients
- New IPCA features:
- Added ncomp_start keyword and documentation
- Minor adaptation of the conditions for breaking out of iterative PCA
- Updated SNR map function to start calculating SNR values beyond 1 FWHM
- Renamed iroll_sub function into iroll and renamed smoothing option in rollsub for consistency with ipca
…ent variables are set to prevent MT when MP is requested, and return to default MT behaviour at the end of MP
… with 4D input cube
…ndition to avoid the warning to be too disruptive
… - re: convolution kernel in ICPA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.