BLD: switch build backend to flit-core #681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I like this |
Contributor
|
Looks very neat. Thanks a lot @neutrinoceros ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very small quality-of-life improvement.
setuptoolsis the historical default build-backend (the definition of which was actually proposed to start and standardize what it does), and it's a very messy one-size-fits-all option that does much more than this package needs.In contrast,
flit-coreis the modern, bare-bones-minimal implementation of PEP 517. Its wheels are ~50kB (compare with >1Mb for setuptools), and it tends to build packages much faster, while still being implemented in pure Python (allowing it to be as portable as setuptools). Its default configuration happen to exactly match what setuptools is configured to do here.Anyway, happy to discuss this small benefit in more details if needed, and no hard feelings if you guys aren't interested.