Skip to content

Conversation

@kluge7
Copy link
Contributor

@kluge7 kluge7 commented Feb 26, 2025

This PR moves the H264Decoder class into a separate file. This is due to import issues where the other utils would fail since they didnt have GI installed, which is only needed by H264Decoder.

@kluge7 kluge7 added bug Something isn't working high priority This issue should be prioritized small ~5 hours to complete labels Feb 26, 2025
@kluge7 kluge7 requested a review from Andeshog February 26, 2025 08:22
@kluge7 kluge7 self-assigned this Feb 26, 2025
@codecov
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 72.72727% with 30 lines in your changes missing coverage. Please review.

Project coverage is 90.63%. Comparing base (82df717) to head (901dc22).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
vortex_utils/gst_utils.py 58.33% 26 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
+ Coverage   90.37%   90.63%   +0.25%     
==========================================
  Files           5        6       +1     
  Lines         395      427      +32     
  Branches       50       53       +3     
==========================================
+ Hits          357      387      +30     
- Misses         24       26       +2     
  Partials       14       14              
Flag Coverage Δ
unittests 90.63% <72.72%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tests/test_utils.py 100.00% <100.00%> (ø)
vortex_utils/python_utils.py 100.00% <ø> (+21.70%) ⬆️
vortex_utils/gst_utils.py 58.33% <58.33%> (ø)

Copy link
Contributor

@Andeshog Andeshog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@kluge7 kluge7 merged commit b6c762b into main Feb 26, 2025
5 checks passed
@kluge7 kluge7 deleted the fix/gi-import-error branch February 26, 2025 08:48
@github-actions
Copy link

🎉 This PR is included in version 1.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working high priority This issue should be prioritized released small ~5 hours to complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants