Resolve LedWizEquivalent outputs via CabinetOutputList (fixes PinOne + FTDI "0 of N resolved")#60
Merged
jsm174 merged 1 commit intoJul 6, 2026
Conversation
…}\{output}" paths)
ResolveOutputs matched output names by direct string equality, so the "{controller}\{output}" reference form the auto-configurators emit (PinOne, FT245R) never matched the flat physical names -> "Resolved 0 of N outputs" -> those toys never fired. The C# original resolves via Cabinet.Outputs[OutputName], whose indexer splits the path on "\". Use the existing CabinetOutputList::GetByName (a faithful port of that indexer) instead of the ad-hoc loop -- this resolves both the hierarchical (PinOne/FTDI) and flat (LedWiz/Pac) reference forms, matching C#. Supersedes the per-controller flatten in vpinball#54.
This was referenced Jul 5, 2026
Collaborator
|
Hello. Thanks for the PR! Converting this to draft as per the contributing rules. (I was behind in getting them added as was just done in Visual Pinball). It's going to take time to review these. libdof is currently is use by several users with a variety of devices, and we have yet to receive issues about this. Also this definitely needs thorough testing with the actual hardware. |
jsm174
marked this pull request as draft
July 5, 2026 18:04
jsm174
marked this pull request as ready for review
July 6, 2026 19:49
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
LedWizEquivalent::ResolveOutputsmatched output names by direct string equality, so the{controller}\{output}reference form the auto-configurators emit (PinOne, FT245R) never matched the flat physical names →Resolved 0 of N outputs→ those toys never fired.The C# original resolves via
Cabinet.Outputs[OutputName], whose indexer (CabinetOutputList[Name], CabinetOutputList.cs) splits the path on\, validates the controller, and matches the output part. libdof already has a faithful port of that indexer —CabinetOutputList::GetByName— butResolveOutputsused an ad-hoc loop instead of it. UseGetByName, exactly as C# does.Why it matters
Resolves both reference forms with one root fix, matching C#:
{ctrl}\{ctrl}.NN(PinOne, FT245R) → now resolves{ctrl}.NN(LedWiz, Pac, Pinscape, DudesCab, …) → still resolves (plain-name path)This is the shared root cause behind the PinOne "Resolved 0 of 63" (#31) and the FTDI "fails to connect to toys" (#40) — fixed once at the resolver rather than by flattening references controller-by-controller. (Fixes the resolution half of #40; the FTDI crash reported there is separate.)
Supersedes #54 (the per-controller PinOne flatten); with this, no reference strings need changing.
Found by diffing the resolution path against the DirectOutput C# source.