downgrade "no scene descriptor" error to a non-blocking warning#88
Merged
cubedparadox merged 1 commit intoreleases/1.2.6from Jun 16, 2023
Merged
Conversation
Faxmashine
approved these changes
May 26, 2023
Contributor
Faxmashine
left a comment
Faxmashine
left a comment
There was a problem hiding this comment.
Good change👍 Let's see how it goes
momo-the-monster
deleted the
feature/60-playmode-without-scene-descriptor
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
old behaviour: trying to run a scene without a scene descriptor for testing, will result in ClientSim kicking you out of play mode.
We decided this was not desirable, following this issue: #60
new behaviour: downgrade the error message to a warning and don't block users, instead disabling ClientSim when they enter play mode in an invalid scene.