Use dart.library.js_interop for Wasm-ready conditional imports - #53
Merged
Conversation
dart.library.js is false under Wasm, so pana selected the native API implementation and reported a dart:io dependency via cookie_jar. Switching to dart.library.js_interop keeps the web implementation on both JS and Wasm, restoring the missing pub points.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dart.library.jswithdart.library.js_interopin web conditional imports so Wasm selects the web API implementation instead of the native/dart:iopath.Test plan
dart pub global run pana vrchat_dartreports Wasm-ready / full platform points