Ship the popular themes beside Dark Modern - #39
Merged
Merged
Conversation
…rk Pro, Tokyo Night, Nord — as the VS Code JSON each publishes, and read that JSON as VS Code does: comments allowed, alpha laid over the ground, the nearest key standing in for one a theme leaves out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six themes now ship: Dark Modern, still the default, and Monokai, Dracula, One Dark Pro, Tokyo Night and Nord — all MIT, each carried as the flattened VS Code theme JSON its extension publishes, under
crates/yara-core/assets/themes/.packaging/themes.py(make themes) fetches them afresh, from a raw URL or out of the Open VSX.vsixfor themes that only build their JSON at packaging time.The loader reads that JSON the way VS Code does, which user-dropped themes gain too:
//comments are allowed — VS Code's own theme files carry them and used to be a hard error.#db4b4b22no longer paints a full-strength red diff line.diffEditor.removedTextBackground,foreground,editorGroup.border, …). The accent preferstextLink.foregroundoverfocusBorder, which several themes keep as quiet as the panel border, so the live pane's border still reads.Tests cover the shipped list, each bundled theme's own palette, tokens and legibility, blending and fallbacks; the themes guide and the settings comment list the six.