Skip to content

Ship the popular themes beside Dark Modern - #39

Merged
vsdudakov merged 2 commits into
mainfrom
bundled-themes
Aug 30, 2026
Merged

Ship the popular themes beside Dark Modern#39
vsdudakov merged 2 commits into
mainfrom
bundled-themes

Conversation

@vsdudakov

Copy link
Copy Markdown
Owner

Six themes now ship: Dark Modern, still the default, and Monokai, Dracula, One Dark Pro, Tokyo Night and Nord — all MIT, each carried as the flattened VS Code theme JSON its extension publishes, under crates/yara-core/assets/themes/. packaging/themes.py (make themes) fetches them afresh, from a raw URL or out of the Open VSX .vsix for themes that only build their JSON at packaging time.

The loader reads that JSON the way VS Code does, which user-dropped themes gain too:

  • // comments are allowed — VS Code's own theme files carry them and used to be a hard error.
  • A translucent colour is blended onto the editor's ground rather than having its alpha dropped; #db4b4b22 no longer paints a full-strength red diff line.
  • Each chrome role has a nearest key to fall back on (diffEditor.removedTextBackground, foreground, editorGroup.border, …). The accent prefers textLink.foreground over focusBorder, which several themes keep as quiet as the panel border, so the live pane's border still reads.
  • A selected row whose ground is as bright as the text (Nord's cyan) falls back to the inactive selection, since the row keeps the ordinary foreground.

Tests cover the shipped list, each bundled theme's own palette, tokens and legibility, blending and fallbacks; the themes guide and the settings comment list the six.

…rk Pro, Tokyo Night, Nord — as the VS Code JSON each publishes, and read that JSON as VS Code does: comments allowed, alpha laid over the ground, the nearest key standing in for one a theme leaves out
@vsdudakov
vsdudakov merged commit 41776a0 into main Aug 30, 2026
4 of 5 checks passed
@vsdudakov
vsdudakov deleted the bundled-themes branch August 30, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant