Add missing א
Merged
Merged
Conversation
I'm not entirely sure how these were missed, but there were still ref and unref calls I wasn't expecting on a hot path. This takes a further five seconds off the startup time of the app I'm working on, so between this and the previous PR, that's nearly half the launch time gone.
Collaborator
|
I'm surprised the compiler isn't doing an optimization of this method to avoid the copy. |
Contributor
Author
|
It's all inline, so in principle you'd think it could see that there aren't any side effects, but maybe it's extra cautious because the ref count is an atomic. The project's compiled as C++20, where atomics can be waited on, so in principle another thread could be poised to do something, in which case the optimisation wouldn't be safe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure how these were missed, but there were still ref and unref calls I wasn't expecting on a hot path. This takes a further five seconds off the startup time of the app I'm working on, so between this and the previous PR, that's nearly half the launch time gone.