Skip to content

fix: rebuild dist to include callout icon fix#87

Merged
julia-rabello merged 1 commit into
mainfrom
fix/rebuild-dist-callout-icon
Jul 10, 2026
Merged

fix: rebuild dist to include callout icon fix#87
julia-rabello merged 1 commit into
mainfrom
fix/rebuild-dist-callout-icon

Conversation

@julia-rabello

Copy link
Copy Markdown
Contributor

Description

Rebuilds dist/ (npm run build) so the callout-icon fix from #86 actually ships in a release.

What problem is this solving?

#86 fixed the callout-icon rendering in source (components.tsx/styles.module.css) but never rebuilt dist/. The release workflow (release-version.yml) only runs standard-version on merge — it does not run npm run build — so v6.1.2 shipped the exact same stale dist/index.css as v6.1.1, still pointing at the dead vtex-dev-portal-navigation DigitalOcean Space.

Confirmed: git log 542ec5e..ab16f4c -- dist/ is empty, and dist/index.css at the v6.1.2 tag still contains digitaloceanspaces.com URLs.

This is why bumping @vtexdocs/components to v6.1.2 in helpcenter (see EDU-19009) had no visible effect — there was nothing fixed to bump to yet.

Verification

dist/index.css no longer contains any digitaloceanspaces references, and includes the new .blockquoteIcon class.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

PR #86 (fix/callout-icon-external-dependency) changed source only and
never rebuilt dist/, so v6.1.2 shipped the exact same stale bundle as
v6.1.1 — still pointing at the dead vtex-dev-portal-navigation
DigitalOcean Space. Consumers bumping to v6.1.2 saw no change because
the fix was never actually built into the published artifacts.
@julia-rabello julia-rabello added the release-patch Patch version bump label Jul 10, 2026
@julia-rabello julia-rabello self-assigned this Jul 10, 2026
@julia-rabello
julia-rabello merged commit 36acb9b into main Jul 10, 2026
2 checks passed
julia-rabello added a commit to vtexdocs/helpcenter that referenced this pull request Jul 10, 2026
v6.1.2 never actually shipped the callout icon fix — dist/ wasn't
rebuilt for that release (see vtexdocs/components#87). v6.1.3 contains
the actual fix and yarn.lock is now regenerated to match.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-patch Patch version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant