fix(runtime-vapor): remove special boolean attributes for falsy values

[christian-byrne]

:readonly="false" renders readonly="false" in Vapor, which makes the input actually read-only. truthy values are written as readonly="true" instead of readonly="". the same applies to the other boolean attributes whose DOM property name differs from the attribute name: itemscope, allowfullscreen, formnovalidate, ismap, nomodule, novalidate.

repro: https://play.vuejs.org/#eNpNjuEKwjAMhF8l5I8K2omCP0Yn+B4FKbWDwtaGNBvI2LsbkYG/kju+O27ByqF5EJl5itiirYETCdQoE8HsqfDd5TTqFViAYw8r9FxG2Glg53IouYr6/lXy8Ibui+x7P9R4cNk2vzqtUCFxpMFLVAVgU6ZJoN2SncPtdaiEbf5wPOJzjlxTybrxam7mfOJgLrh+APS/Q0I=

these keys fail the key in el check in setProp and go through setAttr, which writes the value verbatim. patchAttr guards them with isSpecialBooleanAttr / includeBooleanAttr, so this applies the same guard to setAttr.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a7f0cc1b-1949-447f-85ed-9eb1cd785dc5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[pkg-pr-new]

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@15186

npm i https://pkg.pr.new/@vue/compiler-core@15186

yarn add https://pkg.pr.new/@vue/compiler-core@15186.tgz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@15186

npm i https://pkg.pr.new/@vue/compiler-dom@15186

yarn add https://pkg.pr.new/@vue/compiler-dom@15186.tgz

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@15186

npm i https://pkg.pr.new/@vue/compiler-sfc@15186

yarn add https://pkg.pr.new/@vue/compiler-sfc@15186.tgz

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@15186

npm i https://pkg.pr.new/@vue/compiler-ssr@15186

yarn add https://pkg.pr.new/@vue/compiler-ssr@15186.tgz

@vue/compiler-vapor

pnpm add https://pkg.pr.new/@vue/compiler-vapor@15186

npm i https://pkg.pr.new/@vue/compiler-vapor@15186

yarn add https://pkg.pr.new/@vue/compiler-vapor@15186.tgz

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@15186

npm i https://pkg.pr.new/@vue/reactivity@15186

yarn add https://pkg.pr.new/@vue/reactivity@15186.tgz

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@15186

npm i https://pkg.pr.new/@vue/runtime-core@15186

yarn add https://pkg.pr.new/@vue/runtime-core@15186.tgz

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@15186

npm i https://pkg.pr.new/@vue/runtime-dom@15186

yarn add https://pkg.pr.new/@vue/runtime-dom@15186.tgz

@vue/runtime-vapor

pnpm add https://pkg.pr.new/@vue/runtime-vapor@15186

npm i https://pkg.pr.new/@vue/runtime-vapor@15186

yarn add https://pkg.pr.new/@vue/runtime-vapor@15186.tgz

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@15186

npm i https://pkg.pr.new/@vue/server-renderer@15186

yarn add https://pkg.pr.new/@vue/server-renderer@15186.tgz

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@15186

npm i https://pkg.pr.new/@vue/shared@15186

yarn add https://pkg.pr.new/@vue/shared@15186.tgz

vue

pnpm add https://pkg.pr.new/vue@15186

npm i https://pkg.pr.new/vue@15186

yarn add https://pkg.pr.new/vue@15186.tgz

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@15186

npm i https://pkg.pr.new/@vue/compat@15186

yarn add https://pkg.pr.new/@vue/compat@15186.tgz

commit: 23b874a

[github-actions]

Size Report

Bundles

File	Size	Gzip	Brotli
compiler-dom.global.prod.js	87.1 kB	30.5 kB	26.8 kB
runtime-dom.global.prod.js	115 kB	43.2 kB	38.7 kB
vue.global.prod.js	175 kB	63.3 kB	56.4 kB

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	52.2 kB	20.4 kB	18.6 kB
createApp	61.3 kB	23.7 kB	21.6 kB
createApp + vaporInteropPlugin	114 kB (+38 B)	40.9 kB (+16 B)	36.8 kB (+26 B)
createVaporApp	29.3 kB (+138 B)	11.4 kB (+85 B)	10.5 kB (+69 B)
createSSRApp	66.2 kB	25.6 kB	23.3 kB
createVaporSSRApp	34.5 kB (+139 B)	13.3 kB (+86 B)	12.1 kB (+76 B)
defineCustomElement	67.9 kB	25.7 kB	23.4 kB
defineVaporCustomElement	45 kB (+141 B)	16.5 kB (+84 B)	15.1 kB (+66 B)
overall	76.9 kB	29.3 kB	26.5 kB