Skip to content

2299 duplicate mobile menu items #2300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 18, 2019
Merged

2299 duplicate mobile menu items #2300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b463c17
fix (#2299): Remove duplicate entries on non-home pages
bencodezen Sep 14, 2019
0d1573e
fix (#2299): Improve spacing for sponsors on mobile
bencodezen Sep 14, 2019
c1d58ee
fix (#2299): Align sponsors with content on desktop
bencodezen Sep 14, 2019
8f3f5cf
refactor (#2299): Standardize content padding vertical
bencodezen Sep 14, 2019
0081333
fix (#2299): Improve spacing for clicking on mobile for last sidebar …
bencodezen Sep 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions themes/vue/layout/partials/sidebar.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
<% var isHomePage = page.path === 'index.html' %>

<div class="sidebar">
<div class="sidebar-inner">
<ul class="main-menu">
<%- partial('partials/main_menu', { context: 'sidebar' }) %>
</ul>
<% if (isHomePage) { %>
<ul class="main-menu">
<%- partial('partials/main_menu', { context: 'sidebar' }) %>
</ul>
<% } %>
<div class="list">
<%- partial('partials/sponsors_sidebar') %>
<% if (type !== 'search') { %>
Expand Down
6 changes: 3 additions & 3 deletions themes/vue/source/css/_settings.styl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,16 @@ $red = #ff6666
$info = #1C90F3

$radius = 2px
$content-padding-top = 30px
$content-padding-vertical = 35px

// header settings
$header-inner-height = 41px
$heading-padding-vertical = 10px
$header-height = $header-inner-height + $heading-padding-vertical * 2
$mobile-header-height = 40px
// prevent headers from being covered by the top nav upon navigation
$heading-link-padding-top = $header-height + $content-padding-top
$mobile-heading-link-padding-top = $mobile-header-height + $content-padding-top
$heading-link-padding-top = $header-height + $content-padding-vertical
$mobile-heading-link-padding-top = $mobile-header-height + $content-padding-vertical
$h2-margin-top = 45px
$h3-margin-top = 52px

Expand Down
4 changes: 2 additions & 2 deletions themes/vue/source/css/_sidebar.styl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
margin-top: .5em
.sidebar-inner
width: 260px
padding: $content-padding-top + 40px 0px 60px 20px
padding: $content-padding-vertical 0px 60px 20px
.version-select
vertical-align: middle
margin-left: 5px
Expand Down Expand Up @@ -74,7 +74,7 @@
-webkit-transform: translate(-280px, 0)
transform: translate(-280px, 0)
.sidebar-inner
padding: 50px 10px 10px 20px
Copy link
Member

@phanan phanan Sep 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we take this opportunity to increase the bottom padding of .sidebar-inner to something like 60px as well? The current value (10px) makes it almost possible to tap the last menu item on mobile devices.

image

Copy link
Member Author

@bencodezen bencodezen Sep 16, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phanan I've updated the bottom padding to 30px since the 60px was to account for the header and it would create too much gap.

Here is what it looks like on mobile with the changes I just pushed.

Screen Shot 2019-09-16 at 10 18 10 AM

Let me know if you think we still need more space!

padding: 60px 10px 30px 20px
box-sizing: border-box
.sidebar-inner-index
padding: 10px 10px 10px 20px
Expand Down
3 changes: 0 additions & 3 deletions themes/vue/source/css/_sponsors-sidebar.styl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@
text-align: center
margin-bottom: 20px

#sidebar-sponsors-special
margin-top -10px

#sidebar-sponsors-platinum-left
display block

Expand Down
2 changes: 1 addition & 1 deletion themes/vue/source/css/page.styl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

.content
position: relative
padding: 2.2em 0
padding: $content-padding-vertical 0
max-width: 700px
margin: 0 auto
padding-left: 50px
Expand Down