Skip to content

Conversation

@nriesco
Copy link

@nriesco nriesco commented Nov 23, 2018

No description provided.

@zeekrey
Copy link

zeekrey commented Jan 9, 2019

Hey Nico,
thank you for this PR. Just a short question, why don't you use the @now/static-build builder? I think it's a faster and easier approach since you only need to add a yarn/npm script called "now-build": "yarn build" and a now.json with the following content:

{
    "version": 2,
    "name": "project",
    "builds": [
        { "src": "package.json", "use": "@now/static-build" }
    ]
}

Cheers,
Christian

@privatenumber
Copy link

@zeekrey He does use @now/static-build

@nriesco I think it's also worth mentioning to add "now-build": "npm run build" as a script in package.json

@NataliaTepluhina
Copy link
Member

Thank you for working on this! Unfortunately, need to close the PR in favor of #4232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants