Skip to content

Conversation

@sudo-suhas
Copy link

Add .eslintrc for test folder with env as "mocha". Fix eslint errors in test folders.

Copy link

@gucong3000 gucong3000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is nothing bug code style fix. Low risk.

@sudo-suhas
Copy link
Author

What do you guys think of setting up lint-staged with git pre-commit hook? It can run eslint on the modified files before commit.

@gucong3000
Copy link

gucong3000 commented Jul 19, 2017

setting up lint-staged with git pre-commit hook

First step is add setting up eslint with precommit hook.
I 'd like make a PR.

@sudo-suhas
Copy link
Author

I 'd like make a PR.

Hey @gucong3000 please don't mind, but that sentence is a little ambiguous. Are you saying you'd like it if I made a PR setting up lint-staged or are you saying you will make a PR for it?

@gucong3000
Copy link

gucong3000 commented Jul 19, 2017

both OK,
but vue is not my focus.

@yyx990803 yyx990803 merged commit 5b13502 into vuejs:master Jul 29, 2017
@yyx990803
Copy link
Member

@sudo-suhas feel free to submit a PR for lint-staged!

@sudo-suhas sudo-suhas deleted the chore_eslint_test_conf branch July 30, 2017 02:12
@sudo-suhas
Copy link
Author

@yyx990803 Made a PR for lint-staged - #914

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants