feat($plugin-google-analytics): support option importScript #2208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR,
@vuepress/plugin-google-analyticssupports plugin optionimportScriptwhich specifies how Google Analytics tracking code is imported.vuepress/packages/@vuepress/plugin-google-analytics/index.js
Lines 4 to 7 in b084226
This option accepts one of the following three values:
webpack(default)imports the tracking code into webpack through
enhanceAppFilesand the code will be transpiled and bundled. This is the behaviour of the current version plugin.This works fine, but in google search console, verification via ga tracking code requires the tracking code to be unmodified in
<head>. That is whyheadandhead-alternativeare introduced, both of which import tracking code directly into<head>of html.headimports the tracking code as described in the_google_analytics_tag
head-alternativeimports the tracking code as described in alternative_async_tag
Usage:
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: