chore: Remove every call to the global variable #1613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@DavidRouyer could You add a note to CHANGELOG + UPGRADE NOTES on that as it's possibly a breaking change (if somebody has been using global.$VS)? |
Contributor
Author
|
Will do! |
Collaborator
|
OK, I'm taking this in - please add the docs as separate PR |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
First steps of #1540
Short description and why it's useful
Move global variables to the root store and use Vue.prototype.$isServer
Screenshots of visual changes before/after (if there are any)
Screenshot of passed e2e tests (if you are using our standard setup as a backend)
Contribution and curently important rules acceptance