Skip to content

Conversation

@DavidRouyer
Copy link
Contributor

@DavidRouyer DavidRouyer commented Sep 1, 2018

Related issues

Issue #1540
Continuation of #1613

Short description and why it's useful

Aligned package versions to clean up packages

Screenshots of visual changes before/after (if there are any)

Screenshot of passed e2e tests (if you are using our standard setup as a backend)

Contribution and curently important rules acceptance

@DavidRouyer
Copy link
Contributor Author

I've made some changes to the task callback_event string:

  • If it starts with 'store:', it's dispatched to a Vuex action
  • Otherwise, it's emitted by the event emitter like before, to avoid breaking stuff
    This way, I cleaned up modules/cart/index, modules/stock/index and modules/user/index to avoir those EventBus.$on() handlers on the store. What do you think @pkarw, @filrak, @Igloczek?

@pkarw
Copy link
Collaborator

pkarw commented Sep 1, 2018

This is the best PR from the serie so far :) I really like the way you’ve dealt with the actions like “serverAfterPulled” - bound to the event bus before that.

The only question: have you tested all refactored events if they’re still working?

@DavidRouyer
Copy link
Contributor Author

I haven't tested them, I don't have a fully configured environment with Magento :/

@pkarw pkarw merged commit 37e63be into vuestorefront:develop Sep 4, 2018
@DavidRouyer DavidRouyer deleted the no-globals branch September 4, 2018 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants