Skip to content

Conversation

@grimasod
Copy link
Contributor

Related issues

closes #

Short description and why it's useful

The setting config.storeViews.commonCache was being ignored, because the StorageManager.init function had a default value set to true on the isLocalized parameter. This makes it impossible to have a shared cache (without overriding every core module)

This PR changes the default value of the isLocalized parameter to the config setting

Screenshots of visual changes before/after (if there are any)

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

@andrzejewsky andrzejewsky self-requested a review December 12, 2019 09:52
@andrzejewsky andrzejewsky merged commit 75e8965 into vuestorefront:develop Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants