Skip to content

Use config setting for common cache #3895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 12, 2019
Merged

Use config setting for common cache #3895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
145d85c
Use config setting for common cache
Dec 12, 2019
4a5f4ba
Changelog for #3895
Dec 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Use `defaultSortBy` for sorting category products by default @haelbichalex (#3873)
- Fixed some potential mutations of Config object in `catalog` and `catalog-next` - @grimasod (#3843)
- Set `null` as default value for custom option in product page - @gibkigonzo (#3885)
- Fixed `config.storeViews.commonCache` being ignored - @grimasod (#3895)

### Changed / Improved
- Changed pre commit hook to use NODE_ENV production to check for debugger statements - @resubaka (#3686)
Expand Down
2 changes: 1 addition & 1 deletion core/lib/storage-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const StorageManager = {
* @param isLocalized if set to `false` data will be shared between storeViews (default `true`)
* @param storageQuota max size of storage, 0 if unlimited (default `0`)
*/
init: function (collectionName: string, isLocalized = true, storageQuota = 0) {
init: function (collectionName: string, isLocalized = !config.storeViews.commonCache, storageQuota = 0) {
this.storageMap[collectionName] = _prepareCacheStorage(collectionName, isLocalized, storageQuota)
return this.storageMap[collectionName]
},
Expand Down