fix(NumberField): default the spinbutton's accessible name - #763
Open
sridhar-3009 wants to merge 1 commit into
Open
fix(NumberField): default the spinbutton's accessible name#763sridhar-3009 wants to merge 1 commit into
sridhar-3009 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #741.
NumberField'srole="spinbutton"input readsaria-labelfromroot.label, but that prop has no default — andaria-labelledbyrequires the consumer to point at an existing element. The shapeNumberField's own@exampledocuments supplies neither, so the spinbutton ships with no accessible name at all (axelabel, critical).This is not covered by #640 (
labelledByprop, merged) — that closes the case where a label element exists elsewhere in the DOM, but does nothing when the consumer supplies no naming mechanism at all, which is exactly the documented default shape.Fix
NumberField.Controlnow falls back tolocale.ti('NumberField.label') ?? 'Number'when neitherlabelnorariaLabelledbyis set — matching the precedent already used by the increment/decrement buttons (NumberField.increment/NumberField.decrement), which are already named this way. A consumer-suppliedlabelstill wins, andariaLabelledbystill suppressesaria-labelentirely.Tests
labelprop still wins over the default.139 existing + new component tests pass.