chore(eslint): drop the Foundational import subgroup comment - #779
Merged
Conversation
No ESLint rule enforces this header: grepping eslint.config.js and the resolved eslint-config-vuetify output finds no Foundational subgroup in the perfectionist/sort-imports groups. The comments were hand-written in the original feature commits (e6dcb42, e601c19) and merely preserved by perfectionist, which keeps comments attached to the import below them. Remove the stray subgroup comments so the Composables section matches the single-header norm used everywhere else. SnackbarRoot.vue keeps its copy for now - it is being cleaned on the open PR #774 branch. Verified: full pnpm lint:fix re-run does not re-insert the comments and produces no other changes.
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the stray
// Foundationalsubgroup comments inside the// Composablesimport sections ofSnackbarQueue.vueandTheme/Theme.vue.Investigation: no ESLint rule inserts this header — it appears in neither
eslint.config.jsnor the resolvedeslint-config-vuetifyoutput. The comments were hand-written in the original feature commits (e6dcb42, e601c19) and preserved byperfectionist/sort-imports, which keeps comments attached to the import below them. No config change was needed.SnackbarRoot.vuekeeps its copy — it is being cleaned on the open #774 branch.Verified: full
pnpm lint:fixdoes not re-insert the comments and produces no other changes.