fix(selection): make ticket.unregister() clear selection and tree state - #951
Merged
Conversation
ticket.unregister() now runs the same selectedIds, mixedIds, and nested map cleanup as unregister(id). Group/tree clear and dispose wipe mixed and open state; step() drains reindex before reading selectedIndex; Progress onboard consumes pending apply values.
johnleider
added
T: bug
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ticket.unregister()skipped layer cleanup and left ghost ids inselectedIds,mixedIds, and nested maps. It now matchesunregister(id).Group/tree
clear()anddispose()wipe mixed and open state.step()drains reindex before readingselectedIndex, so removing an earlier item no longer stalls next/prev. Progressonboardconsumes pendingapply()values. Mandatory treeunselectAllskips disabled tickets.