fix go mod#81
Conversation
WalkthroughThe Changes
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (1.64.8)level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package session: could not load export data: no export data for "github.com/vultisig/go-wrappers/go-dkls/sessions"" Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build
🔇 Additional comments (1)
go.mod (1)
10-10:Details
✅ Verification successful
Explicit
github.com/golang/protobufrequirement—verify necessity
Adding a direct dependency ongithub.com/golang/protobuf v1.5.4can be error-prone, since the community has largely migrated togoogle.golang.org/protobuf. If your code doesn’t import it directly, consider marking it// indirector remove it. If you do need it, ensure there are no version conflicts.Run this to check for direct imports:
🏁 Script executed:
#!/bin/bash rg -l '"github.com/golang/protobuf' --glob '*.go'Length of output: 76
Direct import detected – retain
github.com/golang/protobufin go.mod
plugin/payroll/policy.go imports the package directly, so the requirement is necessary.
- File:
plugin/payroll/policy.go- Import:
"github.com/golang/protobuf/proto"No change needed here—keep it as a direct dependency. For long-term maintenance, consider migrating to
google.golang.org/protobufin a future PR.
Summary by CodeRabbit
github.com/golang/protobufand replacednhooyr.io/websocketwithgithub.com/coder/websocket. No impact on user-facing features.