test: account for 0.109.2+ (nightly) assert/error format changes#14
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates tests to accommodate assertion and error message format changes introduced in Nushell version 0.109.2+ (nightly builds). The changes ensure that the test framework correctly handles the new compact error format while maintaining backward compatibility with earlier versions.
Key Changes:
- Removes assertion check for "Assertion failed." text that is no longer present in newer Nushell versions
- Adds version detection to skip tests for compact assertion formatting when running on 0.109.2+
- Updates error formatter to skip compact formatting logic when running on versions where messages are already compact
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/test_orchestrator.nu | Removes check for "Assertion failed." text from test output assertion |
| tests/display/test_display_table_errors.nu | Adds early return logic to skip compact assertion test on 0.109.2+ |
| nutest/formatter.nu | Adds version check to conditionally apply compact formatting based on Nushell version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.