Fix macOS test failures from /var symlink canonicalization#16
Merged
Conversation
Apply path expand to glob results to ensure consistent path resolution. On macOS, /var is a symlink to /private/var, and this ensures both discover suite-files and test assertions return the same canonical paths. Co-authored-by: vyadh <3620650+vyadh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix test failures due to incorrect folder paths
Fix macOS test failures from /var symlink canonicalization
Jan 20, 2026
1 similar comment
vyadh
added a commit
that referenced
this pull request
Jan 20, 2026
* Initial plan * Fix macOS path canonicalization in discover.nu Apply path expand to glob results to ensure consistent path resolution. On macOS, /var is a symlink to /private/var, and this ensures both discover suite-files and test assertions return the same canonical paths. Co-authored-by: vyadh <3620650+vyadh@users.noreply.github.com> * fix: add reasons normalize paths on macOS by expanding symlinks in discover --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: vyadh <3620650+vyadh@users.noreply.github.com> Co-authored-by: Kieron Wilkinson <kieron.wilkinson@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS,
/varis a symlink to/private/var. Tests were failing becauseglobreturns/var/*paths while test assertions usingpath expandexpect/private/var/*.Changes
discover.nuby applyingpath expandto ensure consistent path resolution across platformsThis ensures both discovery and test assertions return the same canonical paths.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.