chore: modernize lexer predicates - #120
Merged
Merged
Conversation
This was referenced Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_multiple_of.map_or(false, ...)withis_some_and.manual_is_multiple_ofandunnecessary_map_orclippy failures without changing behavior.Verification
upstream/main:cargo clippy -q -p jett_lexer --all-targets -- -D warningsreproduces the two targeted failures.cargo fmt --all -- --check— passed.cargo check --workspace— passed.cargo build --workspace— passed.cargo test -q -p jett_lexer— passed (66 tests).cargo clippy -q -p jett_lexer --all-targets -- -D warnings— passed.cargo test -q— passed, including 432 driver fixtures.git diff --check upstream/main...HEAD— passed.Compatibility
usize::is_multiple_ofis stable starting with Rust 1.87. The repository does not currently declare an MSRV or pin a toolchain; the workspace uses Rust 2024 edition.Risk
This was generated by an AI agent (vycdev2). Please verify any changes before merging or applying.