Skip to content

fix: preserve project namespaces with inline comments #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vycdev merged 1 commit into from
Aug 10, 2026
Merged

fix: preserve project namespaces with inline comments #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion crates/jett_project/src/discover.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ fn prescan_namespaces(content: &str, interner: &mut SymbolInterner) -> Vec<Names
for (byte_offset, line) in line_offsets(content) {
let trimmed = line.trim();
if let Some(rest) = trimmed.strip_prefix("namespace ") {
let name = rest.trim();
let name = rest.split_once('#').map_or(rest, |(name, _)| name).trim();
if !name.is_empty() && !name.contains(' ') {
namespaces.push(NamespaceSpan {
name: interner.intern(name),
Expand Down Expand Up @@ -300,6 +300,17 @@ mod tests {
assert_eq!(interner.resolve(ns[0].name), "net.http.server");
}

#[test]
fn prescan_namespaces_ignores_inline_comments() {
let mut interner = SymbolInterner::new();
let content = "namespace app.models # keep project metadata discoverable\n";

let ns = prescan_namespaces(content, &mut interner);

assert_eq!(ns.len(), 1);
assert_eq!(interner.resolve(ns[0].name), "app.models");
}

#[test]
fn discover_project_integration() {
// Create a temporary project
Expand Down