T8782: Document Depends-On built-in merge protection in central config#10
Conversation
Add a documentation comment block above `merge_protections:` so
contributors reading the central Mergify config can discover the
`Depends-On:` PR-body feature without spelunking Mergify's docs.
The protection is built-in: Mergify parses `Depends-On:` lines from
the PR description and blocks merge until every referenced PR has
merged. No YAML is required to enable it, so this is a docs-only
change.
The block covers:
- the three accepted reference syntaxes (#N, owner/repo#N, full URL)
- the same-org / Mergify-enabled constraints
- cross-branch `@Mergifyio refresh` caveat (quoted from docs)
- hypothetical merge-queue interaction (theoretical — no consumer
repo in either org defines queue_rules as of 2026-05-15)
- explicit note that no condition attribute exposes dependency
satisfaction, so `pull_request_rules` cannot label by it
Will be mirrored byte-identical to VyOS-Networks/mergify in a paired
PR (see prior central-config pairs: #7+#5, #8+#6).
🤖 Generated by [robots](https://vyos.io)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📜 Recent review details🧰 Additional context used🔍 Remote MCP Context7Additional Context FoundBased on my research of Mergify documentation and features, I've gathered relevant information to help with the PR review: Mergify Depends-On Feature: Official SpecificationsThe Depends-On feature supports three reference syntaxes: Mergify waits for the linked pull requests to be merged before merging any pull request with a Depends-On: header. Cross-Branch Dependency Caveat (Critical Detail)If the dependency happens between pull requests targeting different branches, the evaluation of the dependent will not be automatic. You might need to use the refresh command to make Mergify realize the dependency has been merged. This aligns with the PR's documented cross-branch Merge Queue Interaction ContextIf PR Built-in/Automatic NatureThese protections are automatically interpreted — no configuration required. This confirms the documentation-only nature of the PR—no functional configuration changes are needed for the Depends-On feature to work. Key Review ObservationsThe documentation in this PR accurately reflects Mergify's official behavior: the three supported syntaxes, same-organization/Mergify-enabled constraints, cycle handling, and the cross-branch refresh requirement. The PR appropriately marks the merge queue interaction as theoretical since VyOS doesn't currently use queue_rules, and correctly notes that dependency satisfaction is not exposed as a condition for pull_request_rules labeling. 🔇 Additional comments (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR adds a documentation-only comment block to ChangesMergify Depends-On Documentation
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@copilot review |
Reviewed the current PR head ( |
CodeRabbit on the mirror PR (VyOS-Networks/mergify) flagged that the literal `vyos/vyos-1x#5191` example contradicts the documented same- organization constraint when read in the VyOS-Networks context. Swap both central configs to a generic `owner/repo#42` placeholder so the block reads identically in either org and the example never contradicts the constraint. 🤖 Generated by [robots](https://vyos.io)
Summary
Adds a documentation comment block above the existing
merge_protections:block so contributors reading the central Mergify config can discover theDepends-On:PR-body feature without spelunking Mergify's built-in-protections docs.The protection is built-in — Mergify parses
Depends-On:lines from the PR description and blocks merge until every referenced PR has merged. No YAML is required to enable it, so this is a docs-only change.What the block covers
#N,owner/repo#N, full PR URL)data/github.md"GitHub App installations")@Mergifyio refreshcaveat, quoted to match the wording in the Pull Request Dependencies Header sectionqueue_rulesas of 2026-05-15pull_request_rulescannot label PRs by dependency stateCompanion PR
To be mirrored byte-identical to
VyOS-Networks/mergifyin a paired PR. Same pattern as prior central-config pairs:Verification
python3 -c "import yaml; yaml.safe_load(open('.mergify.yml'))"→ OKcoderabbit review --base origin/production --agent→ 0 findingsBackport
Not applicable — central config only lives on
production.🤖 Generated by robots