Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require secure context for gamepad state and events #120

Merged
merged 5 commits into from Oct 29, 2020
Merged

Require secure context for gamepad state and events #120

merged 5 commits into from Oct 29, 2020
+19 −4

Conversation

nondebug
Copy link
Collaborator

@nondebug nondebug commented Oct 19, 2019 •
edited by marcoscaceres

Closes #113

The following tasks have been completed:

  • Modified Web platform tests - will be updated automatically after merge.

Implementation commitment:

Preview | Diff

@marcoscaceres marcoscaceres self-requested a review October 24, 2019 23:28
@marcoscaceres
Copy link
Member

Checked the cross references locally also... they are all good 👍

marcoscaceres
marcoscaceres approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shifted order of things... let me know what you think!

index.html Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@marcoscaceres
Copy link
Member

Gecko tracking bug https://bugzilla.mozilla.org/show_bug.cgi?id=1591329

@marcoscaceres
Copy link
Member

About the "secure context" not being linked on TR, filed a bug:
w3c/webappsec-secure-contexts#68

@marcoscaceres marcoscaceres mentioned this pull request Jun 23, 2020
Open
@marcoscaceres
Copy link
Member

Quick updated: landed the console message + returning the empty array + one fire events in secure context in Firefox Nightly. I still need to do the events, but they were breaking a bunch of WebXR things in Gecko, so will need to come back to those.

@beidson
Copy link

beidson commented Jul 31, 2020 •
edited

Adding the logging in WebKit here:
https://bugs.webkit.org/show_bug.cgi?id=214995

Restricting to SecureContext here:
https://bugs.webkit.org/show_bug.cgi?id=215020

@marcoscaceres marcoscaceres merged commit bafd0eb into w3c:gh-pages Oct 29, 2020
esjaysmith pushed a commit to cadenai/byodr that referenced this pull request Nov 25, 2020
HAProxy for secured reverse proxy - getGamepad will now require Secur…
56045b8 
…e Context. For more information see w3c/gamepad#120
@GuyCoast GuyCoast mentioned this pull request Jan 3, 2021
Open
@lycwed lycwed mentioned this pull request Feb 26, 2021
Open
@cbmpvr cbmpvr mentioned this pull request Mar 5, 2021
Open
@NoahBres NoahBres mentioned this pull request Sep 30, 2021
Closed
@goldnchild goldnchild mentioned this pull request Nov 9, 2021
Closed
@andrewfstratton
Copy link

Please can you still allow API to work for local development (and learning)?!

@marcoscaceres
Copy link
Member

marcoscaceres commented Feb 21, 2022 •
edited

Hi @andrewfstratton. In most (all?) browsers, localhost is considered a secure context for development purposes:

https://developer.mozilla.org/en-US/docs/Web/Security/Secure_Contexts#when_is_a_context_considered_secure

@Miniontoby
Copy link

Miniontoby commented Feb 26, 2023 •
edited

[moved to the original issue]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restrict getGamepads() to [SecureContext]
5 participants
@nondebug @marcoscaceres @beidson @andrewfstratton @Miniontoby