Verify URI resolution relative to base without trailing slash#430
Merged
Conversation
Relative resolution in RFC 3986 [1][2] (see `8)` in spec [3]): - `rel` relative to `example` is `example/rel` - `rel` relative to `example/base` is also `example/rel` Already tested elsewhere, for clarity here, with trailing slash: - `rel` relative to `example/base/` is `example/base/rel` [1] https://tools.ietf.org/html/rfc3986#section-5.2 [2] https://blog.cdivilly.com/2019/02/28/uri-trailing-slashes [3] https://w3c.github.io/json-ld-api/#algorithm-4
Member
|
0130 seems to be similar to toRdf/0128, but there isn't an expand version of this AFAICT. Ruby passes them all okay, but pyld fails 0129, so clearly testing a corner case. Looks like the playground (jsonld.js) isn't passing 0129 either. We'll need toRdf versions of these as well, and both expand-manifest.html (and toRdf-manifest.html) should be updated using the |
gkellogg
approved these changes
Mar 24, 2020
Member
|
Also, note that toRdf versions should be named "e129" and "e130" to match the naming scheme for other expansion tests brought over. |
rubensworks
approved these changes
Mar 24, 2020
Member
Author
|
Thanks @gkellogg, I've added toRdf tests and the |
Member
|
Thanks for the extra effort, @fsteeg! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up when fixing jsonld-java/jsonld-java#279 in jsonld-java/jsonld-java#280, where we noticed the original issue described on the Apache Jena list was not covered by the spec tests.
Relative resolution in RFC 3986 [1][2] (see
8)in spec [3]):relrelative toexampleisexample/relrelrelative toexample/baseis alsoexample/relAlready tested elsewhere, for clarity here, with trailing slash:
relrelative toexample/base/isexample/base/rel[1] https://tools.ietf.org/html/rfc3986#section-5.2
[2] https://blog.cdivilly.com/2019/02/28/uri-trailing-slashes
[3] https://w3c.github.io/json-ld-api/#algorithm-4