fix: update OpenAttestationEmbeddedRenderer to EmbeddedRenderer

[isaackps]

Rename "OpenAttestationEmbeddedRenderer" to "EmbeddedRenderer".

As there is an update to OA.

---

Preview | Diff

[dlongley]

A naming question here. What about the renderer itself makes it decentralized?

From the description, it sounds like this is a renderer that uses HTML in an embedded or nested browsing context, in particular, it suggests an iframe must be used. If the latter is true (and intended to be true carrying forward), perhaps IFrameRenderer would be an appropriate name to describe why/how this renderer is different from the other renderer types.

If there's some other layer to the abstraction here and use of an iframe is an implementation detail, perhaps it suggests the name ought to be ExternalRenderer or EmbeddedRenderer -- where there is some External/Embedded "ACTION" API to communicate with it?

If the main feature of this type of renderer is that it has this "ACTION" API communication capability, perhaps the name should be based on that, e.g., ActionableRenderer or ActionDrivenRenderer (or similar). Perhaps those names are slightly awkard or insufficiently specific -- but I wouldn't suggest InteractiveRenderer since "interactivity" could be a property of many different renderer types.

[pohhendry]

Thanks for the thoughtful feedback!

After some discussion within the team, we agree that the name should stay close to how the renderer actually works. Based on your suggestions, we think EmbeddedRenderer would be the most accurate and intuitive choice, since it reflects that the rendering happens in an embedded context.

We’ll proceed with updating the naming accordingly.

[isaackps]

Hi @dlongley,

Thanks for the feedback, have updated it to be EmbeddedRenderer instead.