-
Notifications
You must be signed in to change notification settings - Fork 86
Add 'unsafe-webtransport-hashes' keyword to connect-src #791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
annevk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable overall. @antosart probably needs to review.
antosart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also need to adapt the post-request check? The interaction between fetch an webtransport is not totally clear to me, but I guess it would also go through https://fetch.spec.whatwg.org/#ref-for-should-block-response%E2%91%A0 ?
|
Also, we probably need WPTs. @mikewest after conversations at TPAC, do we already have an updated process for changes to the spec? |
|
No, it's been on my list since TPAC, but I haven't gotten a proposal out yet. Certainly will require WPT coverage and signals from other vendors, though. I think we have the latter here, but not the former? |
|
I've added the post-request check and used " (Unless there are any takers) I'll work on WPT next! |
| 9. Return "`Matches`". | ||
| </ol> | ||
|
|
||
| <h5 id="allow-unsafe-webtransport-hashes" algorithm> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this algorithm is not needed anymore
Fixes #683. Assumes an
unsafe-webtransport-hashesflagon request (seems simplest post w3c/webtransport#697).@dveditz @annevk @martinthomson WDYT?
Preview | Diff