Add a endpoint for creating a new window. #1324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgraham
requested review from
AutomatedTester,
andreastt and
shs96c
as code owners
Member
|
Does this spec follow a testing policy for normative changes, i.e., is a corresponding PR on web-platform-tests required to merge this? |
Member
Author
|
Yes. |
andreastt
previously requested changes
Oct 27, 2018
whimboo
reviewed
Nov 7, 2018
jgraham
force-pushed
the
create_window
branch
2 times, most recently
from
a6d7b9d to
7386aff
Compare
whimboo
reviewed
Nov 7, 2018
whimboo
reviewed
Nov 7, 2018
jgraham
force-pushed
the
create_window
branch
from
7386aff to
b22a82c
Compare
whimboo
reviewed
Nov 9, 2018
whimboo
reviewed
Nov 15, 2018
jgraham
force-pushed
the
create_window
branch
from
b22a82c to
14e72bb
Compare
Contributor
|
implementation and tests in https://bugzilla.mozilla.org/show_bug.cgi?id=1504756 |
AutomatedTester
approved these changes
Nov 22, 2018
Contributor
|
@jgraham can you rebase this please |
Contributor
|
@jgraham and when you rebase feel free to get it landed. |
jgraham
force-pushed
the
create_window
branch
2 times, most recently
from
43daecf to
38741ce
Compare
This adds an endpoint at /session/<session id>/window/new that opens a new top-level browsing context. This takes a single parameter "type" that is used as a hint as to the kind of window to create within the application. The return value includes the handle of the new window and the type of the window that was created.
jgraham
force-pushed
the
create_window
branch
from
38741ce to
b9160cd
Compare
AutomatedTester
approved these changes
Nov 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an endpoint at /session//window/new that opens a
new top-level browsing context. This takes a single parameter "type"
that is used as a hint as to the kind of window to create within the
application. The return value includes the handle of the new window and
the type of the window that was created.
Fixes #1138
Preview | Diff