Merge "get a known element" into "get a known connected element"#1663
Merged
AutomatedTester merged 2 commits intomasterfrom Jun 15, 2022
Merged
Merge "get a known element" into "get a known connected element"#1663AutomatedTester merged 2 commits intomasterfrom
AutomatedTester merged 2 commits intomasterfrom
Conversation
whimboo
requested review from
AutomatedTester,
andreastt,
jgraham and
shs96c
as code owners
Contributor
Author
|
Updates for the wdspec tests will be done via https://bugzilla.mozilla.org/show_bug.cgi?id=1772484. |
jgraham
approved these changes
Jun 13, 2022
Member
jgraham
left a comment
jgraham
left a comment
There was a problem hiding this comment.
I think this is a no-op change because previously get a known connected element was first calling get a known element and then pointlessly doing the connectedness checks again.
If there were cases where we wanted things to work without the connectedness check then we should propose a change so that is stale isn't called from get a known element, but we just check for the right node document.
whimboo
changed the title
Contributor
Author
AutomatedTester
approved these changes
Jun 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #1662. @shs96c please let me know what you think. Thanks.
Preview | Diff