Skip to content

Add wt.reliability attr and {requireUnreliable} constructor option. - #385

Merged
jan-ivar merged 12 commits into
w3c:mainfrom
jan-ivar:unreliable
Mar 31, 2022
Merged

Add wt.reliability attr and {requireUnreliable} constructor option.#385
jan-ivar merged 12 commits into
w3c:mainfrom
jan-ivar:unreliable

Conversation

@jan-ivar

@jan-ivar jan-ivar commented Feb 1, 2022 •
edited by pr-preview Bot
Loading

Copy link
Copy Markdown
Member

Fixes #107.

Preview | Diff

@jan-ivar jan-ivar self-assigned this Feb 1, 2022
@martinthomson

martinthomson commented Feb 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

I think that I would have framed this as tcpFallback: true/false rather than talking about a "datagram mode". Or, to phrase it more positively "quicTransport: true/false" or "http3: true/false". Positive framing might be used to make the truthiness of optional boolean useful.

@jan-ivar

jan-ivar commented Feb 15, 2022

Copy link
Copy Markdown
Member Author

Updated based on feedback at meeting #107 (comment).

@jan-ivar jan-ivar changed the title Add wt.datagrams.mode. Add wt.reliability. Feb 15, 2022
@jan-ivar jan-ivar changed the title Add wt.reliability. Add wt.reliability and {disallowFallback: true} constructor option. Feb 15, 2022
@jan-ivar jan-ivar mentioned this pull request Feb 15, 2022
Closed
jan-ivar
jan-ivar commented Mar 2, 2022
View reviewed changes
Comment thread index.bs Outdated
jan-ivar
jan-ivar commented Mar 2, 2022
View reviewed changes
Comment thread index.bs Outdated
@vasilvv

vasilvv commented Mar 4, 2022

Copy link
Copy Markdown
Contributor

I don't like the way this describes transports as "reliable" vs "unreliable". WebTransport always supports reliable delivery. It sometimes supports unreliable delivery. So the options should be phrased as "reliableOnly" vs "supportsUnreliable".

@jan-ivar jan-ivar changed the title Add wt.reliability and {disallowFallback: true} constructor option. Add wt.reliability attr and {requireUnreliable} constructor option. Mar 15, 2022
@jan-ivar
jan-ivar marked this pull request as ready for review March 15, 2022 11:43
jan-ivar
jan-ivar commented Mar 29, 2022
View reviewed changes
Comment thread index.bs Outdated
jan-ivar
jan-ivar commented Mar 31, 2022
View reviewed changes
Comment thread index.bs Outdated
jan-ivar
jan-ivar commented Mar 31, 2022
View reviewed changes
Comment thread index.bs Outdated
jan-ivar
jan-ivar commented Mar 31, 2022
View reviewed changes
Comment thread index.bs Outdated
jan-ivar
jan-ivar commented Mar 31, 2022
View reviewed changes
Comment thread index.bs Outdated
@jan-ivar
jan-ivar merged commit 4e7243b into w3c:main Mar 31, 2022
@jan-ivar
jan-ivar deleted the unreliable branch March 31, 2022 15:49
github-actions Bot added a commit that referenced this pull request Mar 31, 2022
@jan-ivar @github-actions
Merge pull request #385 from jan-ivar/unreliable
d6f8f7f 
SHA: 4e7243b
Reason: push, by @jan-ivar

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@jan-ivar jan-ivar mentioned this pull request Feb 15, 2023
Closed
@jan-ivar jan-ivar added the Needs test PR needs a WPT test label Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martinthomson martinthomson Awaiting requested review from martinthomson
@aboba aboba Awaiting requested review from aboba
@yutakahirano yutakahirano Awaiting requested review from yutakahirano

Assignees

@jan-ivar jan-ivar

Labels

Editors can integrate Needs test PR needs a WPT test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fallback support

3 participants

@jan-ivar @martinthomson @vasilvv