Proposed Tox and TravisCI for CI/CD#54
Conversation
|
@slick666 Thanks for the pull request 👍 The changes look fine. I will check the changes at my end before merging it. Also, will you be interested in setting up the process to test the asyncio based code for |
|
@rtnpro I would definitely be interested in getting code coverage for all the code, including the asyncio parts. I'm not sure you cover al the problems with simple unit tests though, I'm thinking some functional tests might be appropriate here. (i.e. this unit runs fine, and this unit runs fine but at the same times something fails.) Also, I've set this up to run on my own TravisCI and would be willing to help you set up Travis for the project. |
|
Rebased, should be ready to roll |
|
@rtnpro @sayanchowdhury can this be merged? Is there anything I can to to help it get merged? |
| @@ -1,2 +1,4 @@ | |||
| include README.rst | |||
There was a problem hiding this comment.
It's not redundant but you're right to point it out. I added the README.md file to the manifest but I should have taken the ".rst" file off. I'm assuming that the project switch at some point. The README.md is needed because it's reference in the setup.py file and we need to make sure it's bundled up.
Added simple documentation under the tests folder Added trivial test under the tests folder did simple pep8 cleanup to fix the pep8 tox test Added TravisCI integration
|
rebased |
3 participants
Here is my implementation of a simple testing scheme that would allow devs to run simple unit tests locally and to have all PRs and code be tested simply and automatically. This implementation isn't supposed to really do much testing at all but provide a framework for the work to be filled in as we go. We can leverage TravisCI to automatically test all PRs as they are proposed and know before merging if something is broken. We can add coverage as we have time or work with the effected code.