Skip to content

ci: upgrade outdated actions and cache deps in PR Checks (master)#5150

Merged
leaanthony merged 1 commit into
masterfrom
feature/ci-pr-master-improvements
Apr 14, 2026
Merged

ci: upgrade outdated actions and cache deps in PR Checks (master)#5150
leaanthony merged 1 commit into
masterfrom
feature/ci-pr-master-improvements

Conversation

@leaanthony

@leaanthony leaanthony commented Apr 14, 2026

Copy link
Copy Markdown
Member

Summary

Companion to #5149 (which targets v3-alpha). That PR covers build-and-test-v3.yml and the copy of pr-master.yml on v3-alpha. This PR applies the remaining improvements to pr-master.yml on master, where the file actually runs (GitHub Actions uses the workflow from the base branch of a PR).

1 file changed, 12 insertions, 5 deletions.

Changes

Change Detail Est. Saving
actions/checkout@v3@v4 Both check_docs and test_go jobs Minor — latest checkout speed improvements
actions/setup-go@v3@v5 with cache-dependency-path: v2/go.sum Go module + build cache now active (was completely missing) ~1–2 min per Linux/macOS/Windows job
Raw apt-get update && apt-get installawalsh128/cache-apt-pkgs-action ubuntu-22.04 and ubuntu-24.04 ~30s per Linux job on cache hit

Notes

  • The test_go condition (runs on all pull_request events, not just approvals) was already correct on master — not changed here
  • All YAML validated before push
  • Packages installed are identical to what was there before, just now cached

Related

Summary by CodeRabbit

  • Chores
    • Updated CI/CD infrastructure to use latest action versions and improved build dependency caching for better reliability and performance.

- Upgrade actions/checkout v3 → v4 in both check_docs and test_go
- Upgrade actions/setup-go v3 → v5 with cache-dependency-path: v2/go.sum
  (enables Go module and build cache, was missing previously)
- Replace bare apt-get update/install with awalsh128/cache-apt-pkgs-action
  for ubuntu-22.04 and ubuntu-24.04 (saves ~30s per Linux job on cache hit,
  consistent with how v3 workflows handle Linux deps)

The test_go condition and trigger types were already correct on master.
Companion to #5149 which makes equivalent changes on the v3-alpha branch.
@coderabbitai

coderabbitai Bot commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9cde1de6-d647-45b4-9a7e-e3b33152b2aa

📥 Commits

Reviewing files that changed from the base of the PR and between 7925cb7 and b179e9e.

📒 Files selected for processing (1)
  • .github/workflows/pr-master.yml

📝 Walkthrough

Walkthrough

The GitHub Actions workflow file was updated to use newer action versions and improved dependency management. Action versions were bumped (actions/checkout v3→v4, actions/setup-go v3→v5), dependency installation was switched to use a caching mechanism, and Go module caching was enabled via cache-dependency-path.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Updates
.github/workflows/pr-master.yml
Upgraded action versions (checkout v3→v4, setup-go v3→v5), replaced inline apt-get commands with awalsh128/cache-apt-pkgs-action@latest for caching dependencies across both Ubuntu 22.04 and 24.04 runners, and added Go module caching via cache-dependency-path: v2/go.sum.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

github_actions, v3-alpha, size:XS

Poem

🐰 Hop, hop, the workflows now run sleek,
With caches strong and actions updated each week,
v4 and v5 bring speeds anew,
Dependencies cached—CI skips on through!
Fast as a rabbit, we dash and we bound!

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/ci-pr-master-improvements

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying wails with  Cloudflare Pages  Cloudflare Pages

Latest commit: b179e9e
Status:🚫  Build failed.

View logs

@leaanthony leaanthony marked this pull request as ready for review April 14, 2026 13:57
Copilot AI review requested due to automatic review settings April 14, 2026 13:57
@leaanthony leaanthony merged commit 88a4c97 into master Apr 14, 2026
18 of 19 checks passed
@leaanthony leaanthony deleted the feature/ci-pr-master-improvements branch April 14, 2026 13:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the PR Checks (master) GitHub Actions workflow on master to use newer core actions and enable dependency caching, aiming to reduce CI runtime and improve reliability for PR validation.

Changes:

  • Upgraded actions/checkout from v3 to v4 in both jobs.
  • Upgraded actions/setup-go from v3 to v5 and enabled Go caching via cache-dependency-path: v2/go.sum.
  • Replaced raw apt-get installs with awalsh128/cache-apt-pkgs-action for cached Linux package installation on Ubuntu 22.04/24.04.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 64 to +69
- name: Install linux dependencies (22.04)
uses: awalsh128/cache-apt-pkgs-action@latest
if: matrix.os == 'ubuntu-22.04'
run: sudo apt-get update -y && sudo apt-get install -y libgtk-3-dev libwebkit2gtk-4.0-dev build-essential pkg-config
with:
packages: libgtk-3-dev libwebkit2gtk-4.0-dev build-essential pkg-config
version: 1.0

Copilot AI Apr 14, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awalsh128/cache-apt-pkgs-action is referenced via the mutable @latest tag. This can introduce supply-chain risk and make CI non-deterministic if the action changes or is re-published. Prefer pinning to an immutable ref (a release tag like @v1 if maintained, or a commit SHA) and bump intentionally when upgrading.

Copilot uses AI. Check for mistakes.
if: matrix.os == 'ubuntu-24.04'
run: sudo apt-get update -y && sudo apt-get install -y libgtk-3-dev libwebkit2gtk-4.1-dev build-essential pkg-config
with:
packages: libgtk-3-dev libwebkit2gtk-4.1-dev build-essential pkg-config

Copilot AI Apr 14, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Ubuntu 24.04 dependency list here differs from the v2 build-and-test.yml workflow (which also installs libegl1 on 24.04). This drift can lead to PR checks passing while the main build workflow fails (or vice versa). Consider aligning the package list between the workflows, or add a short note explaining why pr-master.yml intentionally installs a different set.

Suggested change
packages: libgtk-3-dev libwebkit2gtk-4.1-dev build-essential pkg-config
packages: libgtk-3-dev libwebkit2gtk-4.1-dev libegl1 build-essential pkg-config

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants