fix: include new source files in runtime package exports#5797
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe runtime package’s ChangesRuntime metadata
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
leaanthony
left a comment
There was a problem hiding this comment.
Correct change, though the title undersells and slightly misnames it: this is the sideEffects array, not exports.
Worth being precise about the scope, because it affects who benefits. The published tarball ships files: ["./dist", "./types"], so ./src/*.ts is not in it and consumers of the npm package are unaffected either way. Where it matters is consumption from source: the in-repo examples, and anyone linking the runtime with a file: dependency during development. There a bundler resolving the TypeScript sources can tree-shake the side-effectful modules away, and index.ts registering WML is exactly the kind of thing that must survive. Entries that match no file are ignored, so there is no downside for the published package.
Approving. Metadata-only, no runtime behaviour change for published consumers.
…ce files in runtime package exports
Description
I forgot to include those new files and
wails3 build/packagebroke if you import local runtime with non-client test hit support. This fixes the issue.Fixes # (issue)
Type of change
Please select the option that is relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration using
wails doctor.If you checked Linux, please specify the distro and version.
Test Configuration
Please paste the output of
wails doctor. If you are unable to run this command, please describe your environment in as much detail as possible.Checklist:
website/src/pages/changelog.mdxwith details of this PR (v3 changelog entries are added automatically)Summary by CodeRabbit