Fix RuboCop wanring and offenses & Refactor some parts of the code#6
Merged
waiting-for-dev merged 4 commits intowaiting-for-dev:masterfrom Sep 15, 2020
Merged
Conversation
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
waiting-for-dev
approved these changes
Sep 15, 2020
Owner
waiting-for-dev
left a comment
waiting-for-dev
left a comment
There was a problem hiding this comment.
This is simply awesome!! ❤️ Many thanks! Looking forward for the last part 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @waiting-for-dev,
This is an extension of #5. This PR fixes most of the RuboCop offense and warning and refactors some parts of the code.
The CI is greeeeen so nothing is broken! 🎉
cf: https://travis-ci.org/github/utkarsh2102/string-direction/builds/727422485
It partially fixes #4, I'll do the final clean up in one last follow up PR after this! 💪🏻
Let me know what you think about this! 😄
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>