Put example js file in classroom player directory.#264
Merged
walterhiggins merged 1 commit intowalterhiggins:masterfrom Aug 29, 2015
Merged
Conversation
walterhiggins
added a commit
that referenced
this pull request
Aug 29, 2015
Put example js file in classroom player directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR augments classroom-mode behaviour. When a new directory is created for a player, an example javascript file is now also created in this directory. The file is called "greet.js" and contains:
This filename and content match the example discussed in the classroom.js comments.
Why make this change?
We used Scriptcraft classroom-mode at CoderDojo Stirling with a bunch of enthusiastic but non-technical kids.
Setup was pretty challenging, as the kids had to wrap their heads round:
Things went better the second time round, when we ensured there was a js file in-place in their remote player dir (i.e. this PR). So, setup became:
Have you tested the change?
The change has been tested by hand for these cases:
Many thanks for Scriptcraft - it's awesome!
Cheers
Greg
CoderDojo Stirling