Skip to content

Add a few missing block types#326

Merged
walterhiggins merged 1 commit intowalterhiggins:developmentfrom
cgmartin:patch-2
Sep 16, 2017
Merged

Add a few missing block types#326
walterhiggins merged 1 commit intowalterhiggins:developmentfrom
cgmartin:patch-2

Conversation

@cgmartin
Copy link
Copy Markdown
Contributor

@cgmartin cgmartin commented Apr 8, 2017

These were a few missing block types I found in the blocks module in case they are helpful to others.

I made some guesses for key names but unsure if they match your intent at convention (ie. spruce_wood vs wood_spruce).

Much thanks for your OSS work here. It is helping my daughter learn to code.

@TonyGravagno
Copy link
Copy Markdown
Collaborator

Just confirming here that your contribution has not been wasted. I added a bunch of blocks a while back too, and with v1.10-12 there have been a lot of new blocks and concepts added to the game.

I had the same problem that you described: The Bukkit API is very inconsistent. But in discussion with people working on Spigot and other implementations, it seems they're emphatic about not trying to fix inconsistencies, but about pure implementations of the spec. And as much as that irritates me, I believe we need to do the same with ScriptCraft. If we don't follow the API then it will be tougher for people to sync their understanding of Bukkit, Spigot, and the ScriptCraft plugin. One of my code versions (might still be in an unmerged PR here) attempted to accommodate many flavors objects, so there was glass_red, red_glass, etc. That helps when you hit tab to see all the kinds of glass, or to see all the red objects. But it makes for inconsistent code and other issues.

I believe @walterhiggins was considering a new way to define/expose objects than the hardcoding that's in there now. I suggested that we might want to incorporate code (with proper attribution) from PrismarineJS which already has a better way of doing this.

In the near term I hope we can get all new objects into the code using the existing tooling, and look forward to some better mechanism later.

@cgmartin
Copy link
Copy Markdown
Contributor Author

Ok no worries, closing this.

@cgmartin cgmartin closed this Jul 28, 2017
@TonyGravagno
Copy link
Copy Markdown
Collaborator

Re-opening until blocks are added to working code set.

@TonyGravagno TonyGravagno reopened this Jul 28, 2017
@TonyGravagno TonyGravagno self-assigned this Jul 28, 2017
@walterhiggins walterhiggins merged commit 1c6e42d into walterhiggins:development Sep 16, 2017
@TonyGravagno
Copy link
Copy Markdown
Collaborator

Change also added into v3.2.3.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants