include binary path - #782
Open
djps wants to merge 1 commit into
Open
Conversation
Comment on lines
112
to
116
| pml_size=options.pml_size, | ||
| pml_inside=options.pml_inside, | ||
| smooth_p0=False, | ||
| binary_path=cpp_binary, | ||
| ) |
Contributor
There was a problem hiding this comment.
Binary configuration values diverge
When a programmatic caller sets BenchmarkOptions.cpp_binary but does not repeat it as run(cpp_binary=...), the saved options report the custom binary while execution passes None and uses the bundled binary, causing misleading benchmark provenance or a missing-binary failure.
Knowledge Base Used: Native solver integration
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #782 +/- ##
=======================================
Coverage 75.83% 75.83%
=======================================
Files 58 58
Lines 8274 8274
Branches 1614 1614
=======================================
Hits 6275 6275
Misses 1373 1373
Partials 626 626
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #781
Greptile Summary
Adds a benchmark option and CLI argument for selecting a custom C++ solver binary, records that selection in benchmark metadata, and forwards it to solver execution.
BenchmarkOptionswithcpp_binary.--cpp-binaryto the benchmark CLI.Confidence Score: 4/5
The programmatic benchmark configuration should be fixed before merging because it can ignore the configured binary and record misleading benchmark provenance.
BenchmarkOptions.cpp_binaryis serialized as the selected binary, while solver execution instead uses a separately defaultedrun()argument, allowing the recorded configuration and actual executable to diverge.Files Needing Attention: benchmarks/benchmark.py, benchmarks/helpers.py
Important Files Changed
Reviews (1): Last reviewed commit: "include binary path" | Re-trigger Greptile
Context used: