fix(weave): real VCR passthrough for integration tests via vcr_config - #7097
Merged
gtarpenning merged 1 commit intoJun 9, 2026
Merged
Conversation
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=af8abe63a46d67ba32fb3b10b390bbed0e969c6b |
allowed_hosts=[...] on @pytest.mark.vcr is a no-op (pytest-recording only reads it for block_network, not cassette matching), so clickhouse/wandb traffic was never passed through. It bit verifiers_test (9/9 fail on the nightly CH leg) and was latent in 21 other integration suites. Add a shared vcr_config fixture with the real passthrough (ignore_localhost + ignore_hosts=[api.wandb.ai]) and drop the dead allowed_hosts from all 22 files. Co-Authored-By: auto-griffin-claude <auto-griffin-claude@users.noreply.github.com>
gtarpenning
force-pushed
the
auto-griffin-claude/vcr-ignore-localhost-integrations
branch
from
June 8, 2026 22:47
ceef216 to
3cb6df9
Compare
gtarpenning
marked this pull request as ready for review
June 8, 2026 22:54
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
jtschoonhoven
approved these changes
Jun 8, 2026
gtarpenning
deleted the
auto-griffin-claude/vcr-ignore-localhost-integrations
branch
June 9, 2026 01:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WB-35389
Summary
allowed_hosts=[...]on@pytest.mark.vcr(...)is a no-op: pytest-recording only reads it for itsblock_networkfeature, never for cassette matching, so it's passed tovcr.use_cassette()and ignored. ClickHouse/wandb traffic was never actually passed through.verifiers_test(9/9 fail on the nightly CH leg withCannotOverwriteExistingCassetteExceptionon thelocalhost:8123clickhouse-connect request) and was latent in 21 other integration suites.vcr_configfixture (tests/integrations/conftest.py) with the real passthrough (ignore_localhost=True,ignore_hosts=["api.wandb.ai"]) and remove the deadallowed_hostsfrom all 22 files. No cassette records a localhost/wandb request, so no replayed interaction changes.Testing
verified on a real clickhouse backend locally:
verifiers_test1 error->1 passed, and the fullopenaishard27 passed(no regression).