feat(weave): add in-memory fake trace server skeleton and test wiring by andrewtruong · Pull Request #7145 · wandb/weave

andrewtruong · 2026-06-11T00:49:20Z

This PR has two commits:

The first commit introduces the skeleton of the fake trace server implementation, including new wiring to run the impl. Initially, this impl is a no-op to start.
The second commit (most of the changes in this PR) are mechanical additions telling pytest to skip tests against the fake impl. As we implement the fake in subsequent PRs, we'll remove the skips.

At the end of this process, we should have a fully featured fake impl and no skips.

All subsequent PRs in this stack share these properties:

The first commit removes the skip from relevant tests whose impl will be implemented; then
The second commit actually implements the fake, allowing the tests to pass.

andrewtruong · 2026-06-11T00:49:34Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

codecov · 2026-06-11T00:54:12Z

Codecov Report

❌ Patch coverage is 78.72340% with 20 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
weave/trace_server/in_memory_trace_server.py	78.72%	20 Missing ⚠️

📢 Thoughts on this report? Let us know!

w-b-hivemind · 2026-06-13T21:43:48Z

HiveMind Sessions

1 session · 8h 14m · $283

Session	Agent	Duration	Tokens	Cost	Lines
Implement Fake Trace Server PR Stack `805f9d5c-0e5b-46d2-865d-8ad9f5a6969f`	claude	8h 14m	2.1M	$283	+496 -230
Total		8h 14m	2.1M	$283	+496 -230

View all sessions in HiveMind →

Run claude --resume 805f9d5c-0e5b-46d2-865d-8ad9f5a6969f to pickup where you left off.

drtangible

👍 👍 👍

drtangible · 2026-06-16T15:35:48Z

+      contents: read
+    # The in-memory fake needs no ClickHouse/wandb services — it is a pure
+    # in-process backend. Tests it cannot satisfy yet are skipped via
+    # tests/fake_unimplemented.txt; the rest must match ClickHouse.


Is this reference to fake_unimplemented.txt accurate?

No that was removed; fixed

gtarpenning · 2026-06-16T16:00:08Z

+    updated_by: str
+
+
+class InMemoryTraceServer(tsi.FullTraceServerInterface):


why subclass this at all? aren't we going to need to add methods?

What's wrong with subclassing?

gtarpenning · 2026-06-16T16:00:57Z

+# `skipif(FAKE_NOT_IMPLEMENTED, ...)` decorators for the capability it
+# implements, so CI then runs those tests on the fake and verifies they match
+# ClickHouse. (NOT_CLICKHOUSE_BACKEND, by contrast, is permanent CH-only.)
+FAKE_NOT_IMPLEMENTED = (


presumably this will drift from above?

yeah fair, fixed

gtarpenning · 2026-06-16T16:01:33Z

+        self._init_storage()
+
+    def _init_storage(self) -> None:
+        # Calls keyed by id (unique per call in practice; reads filter by


why not key the calls by project_id, id ?

andrewtruong marked this pull request as ready for review June 11, 2026 00:49

andrewtruong requested a review from a team as a code owner June 11, 2026 00:49

andrewtruong marked this pull request as draft June 11, 2026 01:20

andrewtruong force-pushed the andrew/fake-ts-01-skeleton branch 2 times, most recently from 70f64f6 to ec1112c Compare June 11, 2026 04:00

This was referenced Jun 11, 2026

chore(weave): add annotation queues to in-memory trace server #7156

Merged

chore(weave): add completions and agent* methods to in-memory trace server #7157

Merged

andrewtruong changed the title ~~feat(weave): scaffold in-memory fake trace server (storage + SQLite-semantics helpers)~~ feat(weave): scaffold in-memory fake trace server (storage + lifecycle) Jun 11, 2026

andrewtruong changed the base branch from master to graphite-base/7145 June 11, 2026 04:33

andrewtruong force-pushed the andrew/fake-ts-01-skeleton branch from ec1112c to c9a86e6 Compare June 11, 2026 04:33

andrewtruong changed the base branch from graphite-base/7145 to andrew/remove-sqlite-trace-server June 11, 2026 04:33

andrewtruong mentioned this pull request Jun 11, 2026

chore(weave): remove the sqlite trace server #7153

Merged

andrewtruong force-pushed the andrew/fake-ts-01-skeleton branch from c9a86e6 to 91b6e4c Compare June 11, 2026 13:05

andrewtruong force-pushed the andrew/fake-ts-01-skeleton branch 2 times, most recently from d96061d to 9d73269 Compare June 11, 2026 17:06

andrewtruong force-pushed the andrew/remove-sqlite-trace-server branch from c626345 to 38f4846 Compare June 13, 2026 17:16

Base automatically changed from andrew/remove-sqlite-trace-server to master June 13, 2026 20:32

andrewtruong force-pushed the andrew/fake-ts-01-skeleton branch from 9d73269 to 53388a3 Compare June 13, 2026 20:36

andrewtruong force-pushed the andrew/fake-ts-01-skeleton branch 10 times, most recently from 5838d2a to be55e16 Compare June 16, 2026 14:30

andrewtruong marked this pull request as ready for review June 16, 2026 15:04

drtangible approved these changes Jun 16, 2026

View reviewed changes

gtarpenning reviewed Jun 16, 2026

View reviewed changes

gtarpenning approved these changes Jun 16, 2026

View reviewed changes

andrewtruong force-pushed the andrew/fake-ts-01-skeleton branch from be55e16 to b22d2f2 Compare June 16, 2026 20:38

andrewtruong added 2 commits June 16, 2026 16:56

feat(weave): add in-memory fake trace server skeleton and test wiring

9732a1f

test(weave): gate fake-unimplemented tests on the in-memory fake backend

a56135b

andrewtruong force-pushed the andrew/fake-ts-01-skeleton branch from b22d2f2 to a56135b Compare June 17, 2026 02:43

andrewtruong enabled auto-merge (squash) June 17, 2026 02:45

andrewtruong merged commit 0caf63e into master Jun 17, 2026
107 of 108 checks passed

andrewtruong deleted the andrew/fake-ts-01-skeleton branch June 17, 2026 02:58

github-actions Bot locked and limited conversation to collaborators Jun 17, 2026

Navigation Menu

Uh oh!

feat(weave): add in-memory fake trace server skeleton and test wiring - #7145

feat(weave): add in-memory fake trace server skeleton and test wiring#7145
andrewtruong merged 2 commits into
masterfrom
andrew/fake-ts-01-skeleton

andrewtruong commented Jun 11, 2026 •

edited

Loading

Uh oh!

andrewtruong commented Jun 11, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Jun 11, 2026 •

edited

Loading

Uh oh!

w-b-hivemind Bot commented Jun 13, 2026 •

edited

Loading

Uh oh!

drtangible left a comment

Uh oh!

drtangible Jun 16, 2026

Uh oh!

andrewtruong Jun 16, 2026

Uh oh!

gtarpenning Jun 16, 2026

Uh oh!

andrewtruong Jun 16, 2026

Uh oh!

gtarpenning Jun 16, 2026

Uh oh!

andrewtruong Jun 16, 2026

Uh oh!

gtarpenning Jun 16, 2026

Uh oh!

andrewtruong Jun 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		updated_by: str


		class InMemoryTraceServer(tsi.FullTraceServerInterface):

Uh oh!

Conversation

andrewtruong commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrewtruong commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

w-b-hivemind Bot commented Jun 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

HiveMind Sessions

Uh oh!

drtangible left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

andrewtruong commented Jun 11, 2026 •

edited

Loading

andrewtruong commented Jun 11, 2026 •

edited

Loading

codecov Bot commented Jun 11, 2026 •

edited

Loading

w-b-hivemind Bot commented Jun 13, 2026 •

edited

Loading