chore(weave): spans-source alerting schema + gate - #7204
Merged
Conversation
Add source_type/status_match_value + percentage/count aggregations to AlertSpec, a wf_enable_agent_alerting() flag, and broaden the score_agent_spans emit gate to fire when agent alerting is enabled. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
HiveMind Sessions2 sessions · 1m · $0.95
View all sessions in HiveMind → Run |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=5b764c650f9b4ab4c174fcef7cde355ab1005f62 |
gtarpenning
changed the title
Exercise the new code from the spans-source alerting schema PR so codecov/patch goes green: - wf_enable_agent_alerting() env parsing - genai_otel_export kafka emit now fires when scoring OR alerting is enabled Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…e eval The OTel-ingest turn-ended emit is now gated solely on wf_enable_online_eval, matching how the shared kafka producer (and produce_call_end) already behaves. Removes the redundant WEAVE_ENABLE_AGENT_SCORING / WEAVE_ENABLE_AGENT_ALERTING flags, which only ever ORed into this one gate; downstream scoring and alert workers self-gate on their own consumption. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…flag Restore wf_enable_agent_scoring + the original online-eval/scoring emit gate (both pre-existing on master). This PR now only drops the newly-added WEAVE_ENABLE_AGENT_ALERTING; spans alerting rides on WEAVE_ENABLE_AGENT_SCORING. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
gtarpenning
marked this pull request as ready for review
June 25, 2026 19:41
Picks up source_type, status_match_value, and percentage/count aggregation added to WeaveMetricThresholdSpec. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nikumar1206
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
source_type(calls|spans),status_match_value, and percentage/count aggregations toAlertSpec/WeaveMetricThresholdSpec.WEAVE_ENABLE_AGENT_SCORINGgate. The OTel turn-ended events are consumed by both the scoring and alert workers.Testing
unit covers the emit gate; alerting itself covered by the alert-worker spans stack in wandb/core (depends on this).