Skip to content

fix(weave): support $size in ORM - #7589

Merged
jtschoonhoven merged 5 commits into
masterfrom
jon/fix-signals-tab-feedback-pagination
Jul 20, 2026
Merged

fix(weave): support $size in ORM#7589
jtschoonhoven merged 5 commits into
masterfrom
jon/fix-signals-tab-feedback-pagination

Conversation

@jtschoonhoven

@jtschoonhoven jtschoonhoven commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds a Mongo-style $size operand to the trace-server Query DSL. This lets clients express non-empty structured fields with normal Query composition.

This is required by https://github.com/wandb/core/pull/48318 which needs a way to query for empty maps.

@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 44.44444% with 20 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
weave/trace_server/in_memory_trace_server.py 7.69% 12 Missing ⚠️
...server/calls_query_builder/optimization_builder.py 14.28% 5 Missing and 1 partial ⚠️
...er/calls_query_builder/object_ref_query_builder.py 0.00% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@jtschoonhoven
jtschoonhoven marked this pull request as ready for review July 17, 2026 22:03
@jtschoonhoven
jtschoonhoven requested a review from a team as a code owner July 17, 2026 22:03
@jtschoonhoven jtschoonhoven changed the title fix(weave): filter feedback queries to scored rows fix(weave): support $size in ORM Jul 17, 2026

@gtarpenning gtarpenning left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread weave/trace_server/orm.py
Comment thread weave/trace_server/interface/query.py Outdated
Comment thread tests/trace_server/query_builder/test_agent_query_compiler.py
Comment thread tests/trace/test_feedback.py
@w-b-hivemind

w-b-hivemind Bot commented Jul 20, 2026

Copy link
Copy Markdown

HiveMind Sessions

2 sessions · 1m · $0.58

Session Agent Duration Tokens Cost Lines
Address Pr Feedback On Branch
019f806f-5b64-7832-9194-5ff24d9b02ae
codex 8s 7.7K $0.01 +0 -0
Address Pull Request Feedback
019f806f-5ae9-70f1-9e64-8b783c785fbd
codex 1m 46.3K $0.56 +0 -0
Total 1m 54.0K $0.58 +0 -0

View all sessions in HiveMind →

Run codex resume 019f806f-5b64-7832-9194-5ff24d9b02ae to pickup where you left off.

@jtschoonhoven
jtschoonhoven enabled auto-merge (squash) July 20, 2026 17:09
@jtschoonhoven
jtschoonhoven merged commit d40b798 into master Jul 20, 2026
106 of 107 checks passed
@jtschoonhoven
jtschoonhoven deleted the jon/fix-signals-tab-feedback-pagination branch July 20, 2026 17:17
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants