Use in conjunction with other video_player implementation

[Bonfra04]

Describe the bug
I'd like to use FVP only for Linux builds.
For MacOS I'm fine with the default video_player implementation so i can just not include it in the register_with call.
For Windows, instead, I'm trying to experiment with the video_player_win package; this is sadly not possible since FVP implements all the interfaces at once, leading to the following error:

Plugin video_player:windows has conflicting direct dependency implementations:
  fvp
  video_player_win
To fix this issue, remove all but one of these dependencies from pubspec.yaml.

Please resolve the plugin implementation selection errors

Expected behavior
Some way to be more specific about which platform to include plugin-wise.

[wang-bin]

both fvp and video_player_win implement video_player, you must choose one, I can do nothing. you can also report to flutter team.

[Bonfra04]

Maybe is possible to split fvp into a main core and some "addons" like fvp_windows, fvp_linux and so on, and one includes only the needed ones? idk maybe its just too complicated and out of scope

[wang-bin]

Maybe is possible to split fvp into a main core and some "addons" like fvp_windows, fvp_linux and so on, and one includes only the needed ones? idk maybe its just too complicated and out of scope

then the project will not be maintainable, because about 95% code are the same, the only difference is rendering code. what if a plugin supports all platforms and share the same code? i think it's a flaw of flutter. you can fork the repo and modify pubspec.yml to keep only linux platform

[wang-bin]

try master branch. I made changes for flutter 3.27, and should fix this issue

[Bonfra04]

Hi, it seems like just by adding fvp to my pubspec, even if i register it only to other platforms still activates on windows

registerWith(options: {'platforms': [ 'linux' ] })

flutter: AsyncSnapshot<dynamic>(ConnectionState.done, null, UnimplementedError: init() has not been implemented., #0      VideoPlayerPlatform.init (package:video_player_platform_interface/video_player_platform_interface.dart:43:5)
#1      _videoPlayerPlatform (package:video_player/video_player.dart:34:21)
video_player.dart:34
#2      VideoPlayerController.initialize (package:video_player/video_player.dart:440:25)

Do i nee to specify something else in the pubspec?

dependencies:
  video_player_win: # should take care of video playback on windows
  fvp:
    git: https://github.com/wang-bin/fvp.git

[wang-bin]

What's your flutter version? is the error same as fvp 0.28.0?

flutter: AsyncSnapshot(ConnectionState.done, null, UnimplementedError: init() has not been implemented., #0 VideoPlayerPlatform.init (package:video_player_platform_interface/video_player_platform_interface.dart:43:5)

no plugin is used, both video_player_win and fvp are not included. what about removing fvp in dependencies?

[Bonfra04]

What's your flutter version? is the error same as fvp 0.28.0?

flutter --version
Flutter 3.27.1 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 17025dd882 (4 days ago) • 2024-12-17 03:23:09 +0900
Engine • revision cb4b5fff73
Tools • Dart 3.6.0 • DevTools 2.40.2

No the error is different. Using the main version it fails the entire pub get phase. Using the master branch it successfully gets the packages but at runtime it is loaded anyway.

When i remove fvp from the dependencies video_player_win automatically kicks in and its used without any other code modification. Since the same project also compiles for linux it'd be perfect to leave it (fvp) there and expect it to just to be enabled for linux

[wang-bin]

what about removing registerWith?

[Bonfra04]

removing the call to registerWith, seems to fix the problem on windows. fvp correctly steps aside leaving video_player_win free to take the lead. But without that call how is do you manage the specific selection per platform? For example if I want to keep using it on linux and android but not on macos and ios? previously I would've just written those platform in the registerWith.

EDIT
Without the registerWith call by default it seems to never enable fvp, so windows fallsback on other defined methods like video_player_win, android fallsback to exoplayer and so on

[wang-bin]

it's weird. can you debug into registerWith and check VideoPlayerPlatform.instance value before and after the call? fvp may modify the value here https://github.com/wang-bin/fvp/blob/master/lib%2Fsrc%2Fvideo_player_mdk.dart#L128-L133 but should not happen in your case